Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/272#discussion_r167234267
--- Diff:
extras/rya.streams/api/src/test/java/org/apache/rya/streams/api/queries/InMemoryQueryRepositoryTest.java
---
@@ -85,11 +92,16 @@ public void initializedWithPopulatedChangeLog() throws
Exception {
queries.delete( deletedMeId );
// Create a new totally in memory QueryRepository.
- try(final QueryRepository initializedQueries = new
InMemoryQueryRepository( changeLog )) {
+ final QueryRepository initializedQueries = new
InMemoryQueryRepository( changeLog, SCHEDULE );
+ try {
// Listing the queries should work using an initialized
change log.
final Set<StreamsQuery> stored = initializedQueries.list();
assertEquals(expected, stored);
+ } finally {
+ queries.stop();
--- End diff --
This seems redundant with the outer try-finally block calling stop().
Unless the intent is to test it handling 2 consecutive calls to stop(). The
inner try-finally can probably be removed.
---
