[
https://issues.apache.org/jira/browse/RYA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358524#comment-16358524
]
ASF GitHub Bot commented on RYA-443:
------------------------------------
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/272#discussion_r167234267
--- Diff:
extras/rya.streams/api/src/test/java/org/apache/rya/streams/api/queries/InMemoryQueryRepositoryTest.java
---
@@ -85,11 +92,16 @@ public void initializedWithPopulatedChangeLog() throws
Exception {
queries.delete( deletedMeId );
// Create a new totally in memory QueryRepository.
- try(final QueryRepository initializedQueries = new
InMemoryQueryRepository( changeLog )) {
+ final QueryRepository initializedQueries = new
InMemoryQueryRepository( changeLog, SCHEDULE );
+ try {
// Listing the queries should work using an initialized
change log.
final Set<StreamsQuery> stored = initializedQueries.list();
assertEquals(expected, stored);
+ } finally {
+ queries.stop();
--- End diff --
This seems redundant with the outer try-finally block calling stop().
Unless the intent is to test it handling 2 consecutive calls to stop(). The
inner try-finally can probably be removed.
> Implement a single node query manager
> -------------------------------------
>
> Key: RYA-443
> URL: https://issues.apache.org/jira/browse/RYA-443
> Project: Rya
> Issue Type: Task
> Reporter: Andrew Smith
> Assignee: Kevin Chilton
> Priority: Major
>
> We need an application that watches the QueryChangeLog to see when the
> isActive state of queries changes and then reacts to the state change. If
> isActive goes to true, the system must start processing the query. If it is
> false, then it must stop processing the query. This application needs to
> start when the host machine starts. We plan to support CentOS 7.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
