ASF GitHub Bot commented on RYA-485:

GitHub user jdasch opened a pull request:


    RYA-485 Fixed issues with maven-shade-plugin.

    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    ## Description
    - Fixed issues with shade jars being built.
    - Removed the mr profile for the rya.mapreduce shade jar.  Didn't make 
sense when we were automatically building all of the other shade jars.
    - fixed an issue where the rpm-maven-plugin didn't have a version.
    ### Tests
    [Description of what tests were written]
    ### Links
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    #### People To Reivew
    [Add those who should review this]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdasch/incubator-rya candidate/RYA-485

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #288
commit b1d4790751b2547d1091687301f4419fe395ebf0
Author: jdasch <hcsadj@...>
Date:   2018-04-12T12:41:31Z

    RYA-485 Fixed issues with maven-shade-plugin.


> fix maven-shade-plugin usage
> ----------------------------
>                 Key: RYA-485
>                 URL: https://issues.apache.org/jira/browse/RYA-485
>             Project: Rya
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.2.12
>            Reporter: Jeff Dasch
>            Priority: Major
> There are a couple of executions (rya.mapreduce, and others) of the 
> maven-shade-plugin where the shade goal is not specified. This will result 
> the shade jar not being created. Use this grep to find them all:
>  grep -A 20 "maven-shade-plugin" -R .
> While in there, remove any maven-shade-plugin version definition so we defer 
> to the parent pom.
> also fix this bug:
> {code:java}
> [WARNING] Some problems were encountered while building the effective model 
> for org.apache.rya:rya.streams.query-manager:jar:3.2.13-incubating-SNAPSHOT
> [WARNING] 'build.plugins.plugin.version' for 
> org.codehaus.mojo:rpm-maven-plugin is missing. @ 
> org.apache.rya:rya.streams.query-manager:[unknown-version], 
> /Users/jdasch/github/incubator-rya/extras/rya.streams/query-manager/pom.xml, 
> line 177, column 21
> {code}
> Hat tip to Jorge Machado for reporting this regression.

This message was sent by Atlassian JIRA

Reply via email to