Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/291#discussion_r182602468
  
    --- Diff: 
extras/indexing/src/main/java/org/apache/rya/indexing/IndexPlanValidator/ThreshholdPlanSelector.java
 ---
    @@ -111,9 +110,9 @@ public double getCost(TupleExpr te, double indexWeight, 
double commonVarWeight,
             double dirProductScale;
             
             if(queryNodeCount > nodeCount) {
    -            dirProductScale = 1/((double)(queryNodeCount - nodeCount));
    +            dirProductScale = 1/ (queryNodeCount - nodeCount);
    --- End diff --
    
    Are we sure about getting rid of the double casts here? We don't lose 
precision in the division?


---

Reply via email to