[ 
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444473#comment-16444473
 ] 

ASF GitHub Bot commented on RYA-405:
------------------------------------

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/291#discussion_r182602468
  
    --- Diff: 
extras/indexing/src/main/java/org/apache/rya/indexing/IndexPlanValidator/ThreshholdPlanSelector.java
 ---
    @@ -111,9 +110,9 @@ public double getCost(TupleExpr te, double indexWeight, 
double commonVarWeight,
             double dirProductScale;
             
             if(queryNodeCount > nodeCount) {
    -            dirProductScale = 1/((double)(queryNodeCount - nodeCount));
    +            dirProductScale = 1/ (queryNodeCount - nodeCount);
    --- End diff --
    
    Are we sure about getting rid of the double casts here? We don't lose 
precision in the division?


> Migrate from  Sesame to rdf4j libs
> ----------------------------------
>
>                 Key: RYA-405
>                 URL: https://issues.apache.org/jira/browse/RYA-405
>             Project: Rya
>          Issue Type: Improvement
>    Affects Versions: 3.2.12
>            Reporter: Jorge Machado
>            Assignee: Eric White
>            Priority: Major
>             Fix For: 4.0.0
>
>
> I have migrated all the project to the newer libs from rdf4j instead of using 
> the old ones. 
> Can someone take a look ? 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to