Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184127031
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/aggregation/PipelineQueryIT.java
---
@@ -423,28 +423,28 @@ public void testRequiredTimestamp() throws Exception {
+ " ?A rdfs:subClassOf ?B .\n"
+ " ?B rdfs:subClassOf ?A .\n"
+ "}";
- List<String> varNames = Arrays.asList("A", "B");
- Multiset<BindingSet> expectedSolutions = HashMultiset.create();
+ final List<String> varNames = Arrays.asList("A", "B");
+ final Multiset<BindingSet> expectedSolutions =
HashMultiset.create();
expectedSolutions.add(new ListBindingSet(varNames, person,
FOAF.PERSON));
expectedSolutions.add(new ListBindingSet(varNames, FOAF.PERSON,
person));
expectedSolutions.add(new ListBindingSet(varNames, thing,
OWL.THING));
expectedSolutions.add(new ListBindingSet(varNames, OWL.THING,
thing));
// Prepare query and convert to pipeline
- QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
- SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
+ final QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
+ final SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
queryTree.visit(visitor);
Assert.assertTrue(queryTree.getArg() instanceof
AggregationPipelineQueryNode);
- AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
+ final AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
// Extend the pipeline by requiring a timestamp of zero (should
have no effect)
pipelineNode.requireSourceTimestamp(0);
- Multiset<BindingSet> solutions = HashMultiset.create();
+ final Multiset<BindingSet> solutions = HashMultiset.create();
CloseableIteration<BindingSet, QueryEvaluationException> iter =
pipelineNode.evaluate(new QueryBindingSet());
while (iter.hasNext()) {
solutions.add(iter.next());
}
Assert.assertEquals(expectedSolutions, solutions);
// Extend the pipeline by requiring a future timestamp (should
produce no results)
- long delta = 1000 * 60 * 60 * 24;
+ final long delta = 1000 * 60 * 60 * 24;
--- End diff --
Maybe change to TimeUnit.DAYS.toMillis(1);
---
