Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/296#discussion_r187698179
--- Diff:
dao/accumulo.rya/src/main/java/org/apache/rya/accumulo/AccumuloRdfConfiguration.java
---
@@ -62,14 +62,14 @@ public AccumuloRdfConfiguration() {
super();
}
- public AccumuloRdfConfiguration(Configuration other) {
+ public AccumuloRdfConfiguration(final Configuration other) {
super(other);
}
- public AccumuloRdfConfigurationBuilder getBuilder() {
+ public static AccumuloRdfConfigurationBuilder getBuilder() {
--- End diff --
isn't the convention usually builder() for static builder functions?
---
