[ 
https://issues.apache.org/jira/browse/RYA-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472543#comment-16472543
 ] 

ASF GitHub Bot commented on RYA-487:
------------------------------------

Github user isper3at commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/296#discussion_r187708244
  
    --- Diff: 
extras/kafka.connect/accumulo/src/main/java/org/apache/rya/kafka/connect/accumulo/AccumuloRyaSinkConnector.java
 ---
    @@ -0,0 +1,63 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.rya.kafka.connect.accumulo;
    +
    +import java.util.Map;
    +
    +import org.apache.kafka.common.config.AbstractConfig;
    +import org.apache.kafka.common.config.ConfigDef;
    +import org.apache.kafka.connect.connector.Task;
    +import org.apache.rya.kafka.connect.api.sink.RyaSinkConnector;
    +
    +import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
    +import edu.umd.cs.findbugs.annotations.NonNull;
    +import edu.umd.cs.findbugs.annotations.Nullable;
    +
    +/**
    + * A {@link RyaSinkConnector} that uses an Accumulo Rya backend when 
creating tasks.
    + */
    +@DefaultAnnotation(NonNull.class)
    +public class AccumuloRyaSinkConnector extends RyaSinkConnector {
    +
    +    @Nullable
    +    private AccumuloRyaSinkConfig config = null;
    +
    +    @Override
    +    public void start(final Map<String, String> props) {
    +        this.config = new AccumuloRyaSinkConfig( props );
    +    }
    +
    +    @Override
    +    protected AbstractConfig getConfig() {
    +        if(config == null) {
    +            throw new IllegalStateException("The configuration has not 
been set yet. Invoke start(props) first.");
    --- End diff --
    
    usually the doc'd function has the parameters be the type, not the name: 
start(Map)


> Kafka Connect Rya Sink
> ----------------------
>
>                 Key: RYA-487
>                 URL: https://issues.apache.org/jira/browse/RYA-487
>             Project: Rya
>          Issue Type: New Feature
>    Affects Versions: 4.0.0
>            Reporter: Kevin Chilton
>            Assignee: Kevin Chilton
>            Priority: Major
>             Fix For: 4.0.0
>
>
> Implement a Kafka Connect Sink that writes to Rya.
> This sink does not have to handle visibilities.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to