funky-eyes commented on code in PR #6230: URL: https://github.com/apache/incubator-seata/pull/6230#discussion_r1495165314
########## rocketmq/pom.xml: ########## @@ -0,0 +1,53 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <groupId>org.apache.seata</groupId> + <artifactId>seata-parent</artifactId> + <version>${revision}</version> + <relativePath>../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>seata-rocketmq</artifactId> + <packaging>jar</packaging> + <name>seata-rocketmq ${project.version}</name> + <description>rocketmq integration for Seata built with Maven</description> + + <dependencies> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>seata-tcc</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.rocketmq</groupId> + <artifactId>rocketmq-client</artifactId> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.springframework</groupId> + <artifactId>spring-context</artifactId> Review Comment: > 因为现在tcc的action interceptor需要有个实现，如果这里不依赖spring的话就没有办法写TccRocketDefinitionRegistry，producer就拿不到被代理过的bean seata的producer是用户自己将构建producer的参数传递到factory中进行构建，seata的producer不是代理用户的producer为目的。 seata producer is built by the user himself by passing the parameters for building the producer to the factory, seata producer is not a proxy for the user's producer for the purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
