funky-eyes commented on code in PR #6403: URL: https://github.com/apache/incubator-seata/pull/6403#discussion_r1518733301
########## compatible/src/main/java/io/seata/config/ConfigurationChangeEvent.java: ########## Review Comment: 我认为ConfigurationChangeEvent并不属于用户api,即便用户实现了自己的configuration的实现,但是通过这个configurationchangevent并不能与我们内部的configurationchangelistener互通,这块应该是有损的兼容,需要用户改造适配 I think ConfigurationChangeEvent does not belong to the user api, even if the user realizes his own configuration, but through this configurationchangevent and can not communicate with our internal configurationchangelistener, this piece should be detrimental compatibility, the user needs to adapt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
