slievrly commented on code in PR #6420:
URL: https://github.com/apache/incubator-seata/pull/6420#discussion_r1527194236
##########
config/seata-config-core/src/main/java/org/apache/seata/config/ConfigurationCache.java:
##########
@@ -115,6 +76,9 @@ public Configuration proxy(Configuration
originalConfiguration) throws Exception
}
if (null == wrapper
|| (null != defaultValue &&
!Objects.equals(defaultValue, wrapper.lastDefaultValue))) {
+ if (DATA_ID_CACHED.add(rawDataId)) {
+ originalConfiguration.addConfigListener(rawDataId,
this);
Review Comment:
The hierarchical structure of the cache is below that of the config; not
getting the configuration is meaningless for listening purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
