slievrly commented on code in PR #6427:
URL: https://github.com/apache/incubator-seata/pull/6427#discussion_r1527197361
##########
common/src/main/java/org/apache/seata/common/loader/EnhancedServiceLoader.java:
##########
@@ -616,8 +525,17 @@ private List<ExtensionDefinition<S>>
findAllExtensionDefinition(ClassLoader load
return extensionDefinitions;
}
+ private static Class getCompatibleService(Class originType) {
+ String ioSeataType =
originType.getName().replace(APACHE_SEATA_PACKAGE_NAME, IO_SEATA_PACKAGE_NAME);
+ try {
+ return Class.forName(ioSeataType);
+ } catch (ClassNotFoundException e) {
+ return null;
+ }
+ }
+
- private void loadFile(String dir, ClassLoader loader,
List<ExtensionDefinition<S>> extensions)
+ private void loadFile(String dir, Class type, ClassLoader loader,
List<ExtensionDefinition<S>> extensions)
Review Comment:
It seems that the 'type' parameter is not being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
