YeonCheolGit commented on code in PR #6442:
URL: https://github.com/apache/incubator-seata/pull/6442#discussion_r1536846853
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/undo/AbstractUndoLogManager.java:
##########
@@ -264,9 +264,10 @@ public void undo(DataSourceProxy dataSourceProxy, String
xid, long branchId) thr
try {
connectionProxy = dataSourceProxy.getConnection();
conn = connectionProxy.getTargetConnection();
+ originalAutoCommit = conn.getAutoCommit();
// The entire undo process should run in a local transaction.
- if (originalAutoCommit = conn.getAutoCommit()) {
+ if (conn.getAutoCommit()) {
Review Comment:
Thank you for the review.
I intended to divdie assign to variable and check whether is true or not in
If condtion for clarify. `conn.getAutoCommit()` returns only state so i assumed
will be okay for using twice.
What about this alternatively?
```
originalAutoCommit = conn.getAutoCommit();
if (originalAutoCommit)
```
or
```
final boolean autoCommitState = conn.getAutoCommit();
originalAutoCommit = autoCommitState
if (autoCommitState)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
