luky116 commented on code in PR #678: URL: https://github.com/apache/incubator-seata-go/pull/678#discussion_r1563939420
########## CONTRIBUTING.md: ########## @@ -82,15 +82,15 @@ With this remote setting, you can check your git remote configuration like this: $ git remote -v origin [email protected]:<your-username>/seata-go.git (fetch) origin [email protected]:<your-username>/seata-go.git (push) -upstream [email protected]:seata/seata-go.git (fetch) +upstream [email protected]:apache/seata-go.git (fetch) upstream no-pushing (push) ``` Adding this, we can easily synchronize local branches with upstream branches. ### Branch Definition -Right now we assume every contribution via pull request is for [branch develop](https://github.com/seata/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. +Right now we assume every contribution via pull request is for [branch develop](https://github.com/apache/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. Review Comment: https://github.com/apache/seata-go will redirect to https://github.com/apache/incubator-seata-go, it is setted in github ########## CONTRIBUTING.md: ########## @@ -82,15 +82,15 @@ With this remote setting, you can check your git remote configuration like this: $ git remote -v origin [email protected]:<your-username>/seata-go.git (fetch) origin [email protected]:<your-username>/seata-go.git (push) -upstream [email protected]:seata/seata-go.git (fetch) +upstream [email protected]:apache/seata-go.git (fetch) upstream no-pushing (push) ``` Adding this, we can easily synchronize local branches with upstream branches. ### Branch Definition -Right now we assume every contribution via pull request is for [branch develop](https://github.com/seata/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. +Right now we assume every contribution via pull request is for [branch develop](https://github.com/apache/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. Review Comment: > https://github.com/apache/seata-go will redirect to https://github.com/apache/incubator-seata-go, it is setted in github https://github.com/apache/seata-go will redirect to https://github.com/apache/incubator-seata-go, it is setted in github ########## CONTRIBUTING.md: ########## @@ -82,15 +82,15 @@ With this remote setting, you can check your git remote configuration like this: $ git remote -v origin [email protected]:<your-username>/seata-go.git (fetch) origin [email protected]:<your-username>/seata-go.git (push) -upstream [email protected]:seata/seata-go.git (fetch) +upstream [email protected]:apache/seata-go.git (fetch) upstream no-pushing (push) ``` Adding this, we can easily synchronize local branches with upstream branches. ### Branch Definition -Right now we assume every contribution via pull request is for [branch develop](https://github.com/seata/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. +Right now we assume every contribution via pull request is for [branch develop](https://github.com/apache/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. Review Comment: https://github.com/apache/seata-go will redirect to https://github.com/apache/incubator-seata-go, it is setted in github -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
