TakeActionNow2019 commented on code in PR #6511:
URL: https://github.com/apache/incubator-seata/pull/6511#discussion_r1584174146
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/undo/sqlserver/SqlServerUndoDeleteExecutor.java:
##########
@@ -16,21 +16,32 @@
*/
package org.apache.seata.rm.datasource.undo.sqlserver;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.stream.Collectors;
-
import org.apache.seata.common.exception.ShouldNeverHappenException;
import org.apache.seata.common.util.CollectionUtils;
+import org.apache.seata.common.util.IOUtil;
+import org.apache.seata.rm.datasource.ConnectionProxy;
import org.apache.seata.rm.datasource.sql.struct.Field;
+import org.apache.seata.rm.datasource.sql.struct.KeyType;
import org.apache.seata.rm.datasource.sql.struct.Row;
import org.apache.seata.rm.datasource.sql.struct.TableRecords;
import org.apache.seata.rm.datasource.undo.SQLUndoLog;
import org.apache.seata.sqlparser.util.ColumnUtils;
import org.apache.seata.sqlparser.util.JdbcConstants;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
public class SqlServerUndoDeleteExecutor extends BaseSqlServerUndoExecutor {
+
+ private boolean tableIdentifyExistence = false;
Review Comment:
I pondered about it last night. And I found that the cahce key should be a
combination of resourceId, schema and table name. It may be a feasible way to
put it in the subclass of TableMeta. But when I was creating a subclass of
TableMeta named SqlServerTableMeta, I found it a little elegant again. So I
make a compromise and fix it in this way. What do you think of it? Any better
ideas？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
