funky-eyes commented on code in PR #6538:
URL: https://github.com/apache/incubator-seata/pull/6538#discussion_r1691461079
##########
common/src/main/java/org/apache/seata/common/NamingServerConstants.java:
##########
@@ -46,4 +46,24 @@ public interface NamingServerConstants {
* The constant IP_PORT_SPLIT_CHAR
*/
String IP_PORT_SPLIT_CHAR = ":";
+
+ /**
+ * The constant DEFAULT_VGROUP_MAPPING
+ */
+ String DEFAULT_VGROUP_MAPPING = "vgroup_table";
+
+ /**
+ * The constant NAMESPACE_KEY
+ */
+ String NAMESPACE_KEY = "seata.registry.namingserver.namespace";
+
+ /**
+ * The constant CLUSTER_NAME_KEY
+ */
+ String CLUSTER_NAME_KEY = "seata.registry.namingserver.cluster";
+
+ /**
+ * The constant META_PREFIX
+ */
+ String META_PREFIX = "seata.registry.metadata.";
Review Comment:
ditto
##########
common/src/main/java/org/apache/seata/common/NamingServerConstants.java:
##########
@@ -46,4 +46,24 @@ public interface NamingServerConstants {
* The constant IP_PORT_SPLIT_CHAR
*/
String IP_PORT_SPLIT_CHAR = ":";
+
+ /**
+ * The constant DEFAULT_VGROUP_MAPPING
+ */
+ String DEFAULT_VGROUP_MAPPING = "vgroup_table";
+
+ /**
+ * The constant NAMESPACE_KEY
+ */
+ String NAMESPACE_KEY = "seata.registry.namingserver.namespace";
+
+ /**
+ * The constant CLUSTER_NAME_KEY
+ */
+ String CLUSTER_NAME_KEY = "seata.registry.namingserver.cluster";
Review Comment:
ditto
##########
server/pom.xml:
##########
@@ -278,6 +278,11 @@
<groupId>org.codehaus.janino</groupId>
<artifactId>janino</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.codehaus.jackson</groupId>
+ <artifactId>jackson-mapper-asl</artifactId>
+ <version>1.9.13</version>
Review Comment:
依赖管理统一放到dependency模块
Dependency management unified into the dependency module
##########
server/src/main/java/org/apache/seata/server/session/SessionHolder.java:
##########
@@ -70,11 +70,24 @@ public class SessionHolder {
*/
public static final String ROOT_SESSION_MANAGER_NAME = "root.data";
+
+ /**
+ * The constant ROOT_MAPPING_MANAGER_NAME.
+ */
+ public static final String ROOT_MAPPING_MANAGER_NAME = "mapping.json";
Review Comment:
这个只有file会使用，直接放到对应的实现里吧
Only file will use this, so put it directly into the corresponding
implementation.
##########
common/src/main/java/org/apache/seata/common/NamingServerConstants.java:
##########
@@ -46,4 +46,24 @@ public interface NamingServerConstants {
* The constant IP_PORT_SPLIT_CHAR
*/
String IP_PORT_SPLIT_CHAR = ":";
+
+ /**
+ * The constant DEFAULT_VGROUP_MAPPING
+ */
+ String DEFAULT_VGROUP_MAPPING = "vgroup_table";
+
+ /**
+ * The constant NAMESPACE_KEY
+ */
+ String NAMESPACE_KEY = "seata.registry.namingserver.namespace";
Review Comment:
为什么不放到configurationkeys里面？
Why not put it in configurationkeys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
