funky-eyes commented on code in PR #6766:
URL: https://github.com/apache/incubator-seata/pull/6766#discussion_r1724696590
##########
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/fence/FenceHandler.java:
##########
@@ -23,12 +23,17 @@
public interface FenceHandler {
-
+ default void beforePrepareFence(String xid, Long branchId, String
actionName){}
Review Comment:
应该构建一个新的接口，而不是放到fence里，before和after的hook应该由fencehandle之上的地方去调用，而不是耦合在fencehandle中
A new interface should be built, not put in the fence. The before and after
hooks should be called by the place above the fencehandle, not coupled in the
fencehandle.
##########
changes/zh-cn/2.x.md:
##########
@@ -60,7 +60,7 @@
- [[#6755](https://github.com/apache/incubator-seata/pull/6755)]
优化namingserver代码逻辑
- [[#6763](https://github.com/apache/incubator-seata/pull/6763)] 优化
NacosConfiguration 单例加载
- [[#6761](https://github.com/apache/incubator-seata/pull/6761)]
提升namingserver manager代码可读性
-
+- [[#6766](https://github.com/apache/incubator-seata/pull/6766)] 添加tcc
fence钩子函数, 方便用户在tcc三阶段前后进行逻辑拓展（比如多数据源的切换操作）
Review Comment:
应该写到feature中
Should be written in the feature
##########
changes/en-us/2.x.md:
##########
@@ -59,7 +59,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6755](https://github.com/apache/incubator-seata/pull/6755)] optimize
namingserver code logic
- [[#6763](https://github.com/apache/incubator-seata/pull/6763)] optimize
NacosConfiguration singleton reload
- [[#6761](https://github.com/apache/incubator-seata/pull/6761)] optimize the
namingserver code to improve readability
-
+- [[#6766](https://github.com/apache/incubator-seata/pull/6766)] add tcc fence
hook function
Review Comment:
应该写到feature中
Should be written in the feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
