funky-eyes commented on code in PR #6945:
URL: https://github.com/apache/incubator-seata/pull/6945#discussion_r1814460630


##########
discovery/seata-discovery-nacos/src/main/java/org/apache/seata/discovery/registry/nacos/NacosRegistryServiceImpl.java:
##########
@@ -194,8 +194,9 @@ public List<InetSocketAddress> lookup(String key) throws 
Exception {
                                     .map(eachInstance -> new 
InetSocketAddress(eachInstance.getIp(), eachInstance.getPort()))
                                     .collect(Collectors.toList());
                             CLUSTER_ADDRESS_MAP.put(clusterName, 
newAddressList);
-
-                            
removeOfflineAddressesIfNecessary(transactionServiceGroup, clusterName, 
newAddressList);
+                            if 
(StringUtils.isNotEmpty(transactionServiceGroup)) {

Review Comment:
   I think we should solve the problem of why the current transaction group is 
empty, instead of simply adding an empty judgment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to