No-SilverBullet commented on code in PR #686:
URL:
https://github.com/apache/incubator-seata-go/pull/686#discussion_r1835634714
##########
pkg/datasource/sql/datasource/mysql/trigger.go:
##########
@@ -144,7 +144,9 @@ func (m *mysqlTrigger) getColumnMetas(ctx context.Context,
dbName string, table
columnMeta.Autoincrement =
strings.Contains(strings.ToLower(extra), "auto_increment")
columnMetas = append(columnMetas, columnMeta)
}
-
+ if err := rows.Err(); err != nil {
+ return nil, err
Review Comment:
<img width="1156" alt="image"
src="https://github.com/user-attachments/assets/03598a8c-f7a9-4005-8665-e1c71defce18";>
based on the description above, i think this is a potential bug, so added
the error handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
