slievrly commented on code in PR #7005:
URL: https://github.com/apache/incubator-seata/pull/7005#discussion_r1845494242
##########
server/src/main/java/org/apache/seata/server/coordinator/DefaultCore.java:
##########
@@ -308,65 +321,75 @@ public GlobalStatus rollback(String xid) throws
TransactionException {
@Override
public boolean doGlobalRollback(GlobalSession globalSession, boolean
retrying) throws TransactionException {
- boolean success = true;
- // start rollback event
- MetricsPublisher.postSessionDoingEvent(globalSession, retrying);
+ return SessionHolder.lockAndExecute(globalSession, () -> {
Review Comment:
Expect lock-free implementation to reduce code complexity and increase
maintainability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
