baerwang commented on code in PR #725:
URL:
https://github.com/apache/incubator-seata-go/pull/725#discussion_r1870717925
##########
pkg/datasource/sql/undo/builder/mysql_insertonduplicate_update_undo_log_builder.go:
##########
@@ -97,68 +97,119 @@ func (u *MySQLInsertOnDuplicateUndoLogBuilder)
buildBeforeImageSQL(insertStmt *a
if err := checkDuplicateKeyUpdate(insertStmt, metaData); err != nil {
return "", nil, err
}
- var selectArgs []driver.Value
+
+ // Reset primary keys map
+ u.BeforeImageSqlPrimaryKeys = make(map[string]bool)
+
pkIndexMap := u.getPkIndex(insertStmt, metaData)
var pkIndexArray []int
for _, val := range pkIndexMap {
- tmpVal := val
- pkIndexArray = append(pkIndexArray, tmpVal)
+ pkIndexArray = append(pkIndexArray, val)
}
insertRows, err := getInsertRows(insertStmt, pkIndexArray)
if err != nil {
return "", nil, err
}
- insertNum := len(insertRows)
paramMap, err := u.buildImageParameters(insertStmt, args, insertRows)
if err != nil {
return "", nil, err
}
+ if len(paramMap) == 0 || len(metaData.Indexs) == 0 {
+ return "", nil, nil
+ }
+ hasPK := false
+ for _, index := range metaData.Indexs {
+ if strings.EqualFold("PRIMARY", index.Name) {
+ hasPK = true
+ break
+ }
+ }
+ if !hasPK {
+ return "", nil, nil
+ }
+ var sql strings.Builder
+ sql.WriteString("SELECT * FROM " + metaData.TableName + " ")
- sql := strings.Builder{}
- sql.WriteString("SELECT * FROM " + metaData.TableName + " ")
+ var selectArgs []driver.Value
isContainWhere := false
- for i := 0; i < insertNum; i++ {
- finalI := i
- paramAppenderTempList := make([]driver.Value, 0)
+ hasConditions := false
+ for i := 0; i < len(insertRows); i++ {
+ var rowConditions []string
+ var rowArgs []driver.Value
+ usedParams := make(map[string]bool)
Review Comment:
add cap
##########
pkg/datasource/sql/undo/builder/mysql_insertonduplicate_update_undo_log_builder.go:
##########
@@ -97,68 +97,119 @@ func (u *MySQLInsertOnDuplicateUndoLogBuilder)
buildBeforeImageSQL(insertStmt *a
if err := checkDuplicateKeyUpdate(insertStmt, metaData); err != nil {
return "", nil, err
}
- var selectArgs []driver.Value
+
+ // Reset primary keys map
+ u.BeforeImageSqlPrimaryKeys = make(map[string]bool)
+
pkIndexMap := u.getPkIndex(insertStmt, metaData)
var pkIndexArray []int
for _, val := range pkIndexMap {
- tmpVal := val
- pkIndexArray = append(pkIndexArray, tmpVal)
+ pkIndexArray = append(pkIndexArray, val)
}
insertRows, err := getInsertRows(insertStmt, pkIndexArray)
if err != nil {
return "", nil, err
}
- insertNum := len(insertRows)
paramMap, err := u.buildImageParameters(insertStmt, args, insertRows)
if err != nil {
return "", nil, err
}
+ if len(paramMap) == 0 || len(metaData.Indexs) == 0 {
+ return "", nil, nil
+ }
+ hasPK := false
Review Comment:
use `goto`
##########
pkg/datasource/sql/undo/builder/mysql_insertonduplicate_update_undo_log_builder.go:
##########
@@ -97,68 +97,119 @@ func (u *MySQLInsertOnDuplicateUndoLogBuilder)
buildBeforeImageSQL(insertStmt *a
if err := checkDuplicateKeyUpdate(insertStmt, metaData); err != nil {
return "", nil, err
}
- var selectArgs []driver.Value
+
+ // Reset primary keys map
+ u.BeforeImageSqlPrimaryKeys = make(map[string]bool)
+
pkIndexMap := u.getPkIndex(insertStmt, metaData)
var pkIndexArray []int
Review Comment:
use make and cap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
