luky116 commented on code in PR #684:
URL:
https://github.com/apache/incubator-seata-go/pull/684#discussion_r1894603495
##########
pkg/rm/tcc/fence/handler/tcc_fence_wrapper_handler.go:
##########
@@ -110,37 +110,37 @@ func (handler *tccFenceWrapperHandler) CommitFence(ctx
context.Context, tx *sql.
return handler.updateFenceStatus(tx, xid, branchId,
enum.StatusCommitted)
}
-func (handler *tccFenceWrapperHandler) RollbackFence(ctx context.Context, tx
*sql.Tx) error {
+func (handler *tccFenceWrapperHandler) RollbackFence(ctx context.Context, tx
*sql.Tx) (bool, error) {
xid := tm.GetBusinessActionContext(ctx).Xid
branchId := tm.GetBusinessActionContext(ctx).BranchId
actionName := tm.GetBusinessActionContext(ctx).ActionName
fenceDo, err := handler.tccFenceDao.QueryTCCFenceDO(tx, xid, branchId)
if err != nil {
- return fmt.Errorf("rollback fence method failed. xid= %s,
branchId= %d, [%w]", xid, branchId, err)
+ return false, fmt.Errorf("rollback fence method failed. xid=
%s, branchId= %d, [%w]", xid, branchId, err)
}
// record is null, mean the need suspend
if fenceDo == nil {
err = handler.insertTCCFenceLog(tx, xid, branchId, actionName,
enum.StatusSuspended)
if err != nil {
- return fmt.Errorf("insert tcc fence record errors,
rollback fence failed. xid= %s, branchId= %d, [%w]", xid, branchId, err)
+ return false, fmt.Errorf("insert tcc fence record
errors, rollback fence failed. xid= %s, branchId= %d, [%w]", xid, branchId, err)
}
log.Infof("Insert tcc fence suspend record xid: %s, branchId:
%d", xid, branchId)
- return nil
+ return true, tx.Commit()
Review Comment:
这里是否要执行 commit？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
