Code-Fight commented on code in PR #739:
URL:
https://github.com/apache/incubator-seata-go/pull/739#discussion_r1894611294
##########
pkg/datasource/sql/datasource/base/meta_cache.go:
##########
@@ -92,7 +110,7 @@ func (c *BaseTableMetaCache) refresh(ctx context.Context) {
for i := range v {
tm := v[i]
- if _, ok := c.cache[tm.TableName]; !ok {
+ if _, ok := c.cache[tm.TableName]; ok {
Review Comment:
> 这里是不是都得去刷新，而不用去判断原来是否存在？
我看java的实现也是先判断有没有，然后再去更新有的
<img width="795" alt="image"
src="https://github.com/user-attachments/assets/fba0e46d-d0aa-491a-8c38-e5eb877b0390";
/>
如果直接更新也行，不过也要判断，要加个初始化
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
