liuzhebaba commented on code in PR #7071:
URL: https://github.com/apache/incubator-seata/pull/7071#discussion_r1895389542


##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/DataSourceProxy.java:
##########
@@ -210,6 +210,11 @@ public String getDbType() {
     @Override
     public ConnectionProxy getConnection() throws SQLException {
         Connection targetConnection = targetDataSource.getConnection();
+        //如果是读写分离,在用aop设置主库的时候,会走这里,需要重新设置resourceId
+        if (targetConnection!=null) {
+            this.jdbcUrl = targetConnection.getMetaData().getURL();

Review Comment:
   
在真正执行的时候,targetConnection才是它真正使用到的connection,外面的ConnectionProxy并不一定是其真正使用的connection,所以使用targetConnection来确定resourceId是最为准确的。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to