funky-eyes commented on code in PR #7073:
URL: https://github.com/apache/incubator-seata/pull/7073#discussion_r1901529437
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/xa/ConnectionProxyXA.java:
##########
@@ -127,10 +130,12 @@ private void xaEnd(XAXid xaXid, int flags) throws
XAException {
* @param applicationData application data
* @throws SQLException SQLException
*/
- public synchronized void xaCommit(String xid, long branchId, String
applicationData) throws XAException {
- XAXid xaXid = XAXidBuilder.build(xid, branchId);
- xaResource.commit(xaXid, false);
- releaseIfNecessary();
+ public void xaCommit(String xid, long branchId, String applicationData)
throws XAException {
Review Comment:
我认为这点还是可以接受的，因为
I think this is still acceptable because
```
synchronized(this){
}
```
与
with
```
try(ResourceLock ignored = resourceLock.obtain()){
}
```
书写方式区别不大。
The writing style is not much different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
