funky-eyes commented on code in PR #7102: URL: https://github.com/apache/incubator-seata/pull/7102#discussion_r1916136541
########## rm-datasource/src/main/java/org/apache/seata/rm/datasource/xa/ConnectionProxyXA.java: ########## @@ -117,6 +117,10 @@ private void xaEnd(XAXid xaXid, int flags) throws XAException { if (!xaEnded) { xaResource.end(xaXid, flags); xaEnded = true; + } else { + if (flags == XAResource.TMSUCCESS) { Review Comment: 为什么只有TMSUCCESS才需要end?join进来的不再end了吗? 假设事务1 commit,事务2继续用这个connection commit(等于先join)走到这个xaend,就不执行xaend了?还有rollback的时候会走到这个xaend方法,此时rollback不直接end,直接进行rollback吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org