funky-eyes commented on code in PR #7135:
URL: https://github.com/apache/incubator-seata/pull/7135#discussion_r1942565643
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/undo/AbstractUndoLogManager.java:
##########
@@ -400,6 +400,8 @@ public void undo(DataSourceProxy dataSourceProxy, String
xid, long branchId) thr
if (LOGGER.isInfoEnabled()) {
LOGGER.info("xid {} branch {}, undo_log inserted, retry
rollback", xid, branchId);
}
+ throw new
BranchTransactionException(BranchRollbackFailed_Unretriable, String.format(
Review Comment:
It should not be written here; the exception handling should be done in
`undoExecutor.executeOn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
