funky-eyes commented on code in PR #7114:
URL: https://github.com/apache/incubator-seata/pull/7114#discussion_r1958911890


##########
namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java:
##########
@@ -152,7 +154,9 @@ public Result<String> createGroup(String namespace, String 
vGroup, String cluste
             LOGGER.error("no instance in cluster {}", clusterName);
             return new Result<>("301", "no instance in cluster" + clusterName);
         } else {
-            Node node = nodeList.get(0);
+            Node node =
+                nodeList.stream().filter(n -> n.getRole() == 
ClusterRole.LEADER || n.getRole() == ClusterRole.MEMBER)

Review Comment:
   For a Raft cluster, you need to find the leader to create the group, whereas 
for a regular cluster, you need to find a member to create the group.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to