funky-eyes commented on code in PR #7162:
URL: https://github.com/apache/incubator-seata/pull/7162#discussion_r1958914684
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingServer.java:
##########
@@ -68,28 +69,28 @@ public AbstractNettyRemotingServer(ThreadPoolExecutor
messageExecutor, NettyServ
@Override
public Object sendSyncRequest(String resourceId, String clientId, Object
msg, boolean tryOtherApp)
- throws TimeoutException {
+ throws TimeoutException, IOException {
Channel channel = ChannelManager.getChannel(resourceId, clientId,
tryOtherApp);
if (channel == null) {
- throw new RuntimeException("rm client is not connected. dbkey:" +
resourceId + ",clientId:" + clientId);
+ throw new IOException("rm client is not connected. dbkey:" +
resourceId + ",clientId:" + clientId);
Review Comment:
Why is it considered an IO exception when a channel does not exist, rather
than a runtime exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
