funky-eyes commented on code in PR #7133:
URL: https://github.com/apache/incubator-seata/pull/7133#discussion_r1958922216
##########
server/src/main/java/org/apache/seata/server/session/SessionHelper.java:
##########
@@ -454,6 +454,25 @@ public static void removeAllBranch(GlobalSession
globalSession, boolean isAsync)
}
}
+ public static void processEndState(GlobalSession globalSession) throws
TransactionException {
+ GlobalStatus globalStatus = globalSession.getStatus();
+
+ switch (globalStatus) {
+ case CommitFailed:
Review Comment:
```suggestion
case Committed:
```
##########
server/src/main/java/org/apache/seata/server/session/SessionHelper.java:
##########
@@ -454,6 +454,25 @@ public static void removeAllBranch(GlobalSession
globalSession, boolean isAsync)
}
}
+ public static void processEndState(GlobalSession globalSession) throws
TransactionException {
+ GlobalStatus globalStatus = globalSession.getStatus();
+
+ switch (globalStatus) {
+ case CommitFailed:
+ case Finished:
+ endCommitted(globalSession, true);
+ return;
+ case Rollbacked:
+ case TimeoutRollbacked:
+ case RollbackFailed:
+ case TimeoutRollbackFailed:
Review Comment:
```suggestion
```
##########
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java:
##########
@@ -189,12 +197,16 @@ public class DefaultCoordinator extends
AbstractTCInboundHandler implements Tran
private final GlobalStatus[] retryRollbackingStatuses = new GlobalStatus[]
{
GlobalStatus.TimeoutRollbacking,
- GlobalStatus.TimeoutRollbackRetrying, GlobalStatus.RollbackRetrying};
+ GlobalStatus.TimeoutRollbackRetrying,
+ GlobalStatus.RollbackRetrying
+ };
private final GlobalStatus[] retryCommittingStatuses = new GlobalStatus[]
{GlobalStatus.CommitRetrying, GlobalStatus.Committed};
private final GlobalStatus[] rollbackingStatuses = new GlobalStatus[]
{GlobalStatus.Rollbacking};
private final GlobalStatus[] committingStatuses = new GlobalStatus[]
{GlobalStatus.Committing};
+ private final GlobalStatus[] endStatuses = new GlobalStatus[]
{GlobalStatus.Rollbacked, GlobalStatus.TimeoutRollbacked,
+ GlobalStatus.CommitFailed, GlobalStatus.RollbackFailed,
GlobalStatus.TimeoutRollbackFailed, GlobalStatus.Finished};
Review Comment:
```suggestion
private final GlobalStatus[] endStatuses = new GlobalStatus[]
{GlobalStatus.Rollbacked, GlobalStatus.Committed, GlobalStatus.Finished};
```
##########
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java:
##########
@@ -189,12 +197,16 @@ public class DefaultCoordinator extends
AbstractTCInboundHandler implements Tran
private final GlobalStatus[] retryRollbackingStatuses = new GlobalStatus[]
{
GlobalStatus.TimeoutRollbacking,
- GlobalStatus.TimeoutRollbackRetrying, GlobalStatus.RollbackRetrying};
+ GlobalStatus.TimeoutRollbackRetrying,
+ GlobalStatus.RollbackRetrying
+ };
private final GlobalStatus[] retryCommittingStatuses = new GlobalStatus[]
{GlobalStatus.CommitRetrying, GlobalStatus.Committed};
Review Comment:
```suggestion
private final GlobalStatus[] retryCommittingStatuses = new
GlobalStatus[] {GlobalStatus.CommitRetrying};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
