lyl2008dsg commented on code in PR #7095:
URL: https://github.com/apache/incubator-seata/pull/7095#discussion_r1976331224
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -222,6 +229,7 @@ public void sendAsyncRequest(Channel channel, Object msg) {
public void sendAsyncResponse(String serverAddress, RpcMessage rpcMessage,
Object msg) {
RpcMessage rpcMsg = buildResponseMessage(rpcMessage, msg,
ProtocolConstants.MSGTYPE_RESPONSE);
Channel channel = clientChannelManager.acquireChannel(serverAddress);
+ channelToRequestIds.computeIfAbsent(channel, ch ->
ConcurrentHashMap.newKeySet()).add(rpcMessage.getId());
Review Comment:
After reviewing the code, it's clear that AsyncSend doesn't wait on a
Future—it handles outcomes via callbacks. Thus, fast-failure isn't needed in
this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
