slievrly commented on PR #7176: URL: https://github.com/apache/incubator-seata/pull/7176#issuecomment-2708295901
> > @YongGoose some UT cases failed. https://github.com/apache/incubator-seata/actions/runs/13701955489/job/38317801470?pr=7176 > > I also saw the UT cases failed. However, I can’t figure out why the test is failing. > > To explain in more detail, I can see that `testIsSuccess` in `ResultTest` has failed. > > > org.opentest4j.AssertionFailedError: expected: but was: > > at org.apache.seata.common.result.ResultTest.testIsSuccess(ResultTest.java:36) > > This test checks the isSuccess method of the `Result` class, verifying whether the code consists of the string `200`. > > ``` > public boolean isSuccess() { > return this.code.equals(SUCCESS.code); > } > > --- > > SUCCESS("200", "ok"), > ``` > > When checking the unit test, I can confirm that the values `200` and `ok` are being set correctly. > > ``` > @Test > void testIsSuccess() { > Result result = new Result("200", "ok"); > Assertions.assertTrue(result.isSuccess()); > } > ``` > > @slievrly What do you think? It was a little confusing. I can run your PR code locally and it will pass the unit test. Maybe it's not the code itself, and I'll try to pinpoint the cause. > PS. please assign below issue to me :) I'll do my best to implement this issue > > * [Enhance E2E Testing in seata-samples with Multiple Environment Combinations #7178](https://github.com/apache/incubator-seata/issues/7178) I have already commented on this issue. > And I’m interested in your mission among Seata’s GSOC missions. 🙂 Are you talking about this GSoC project? https://cwiki.apache.org/confluence/display/COMDEV/GSoC+2025+Ideas+list#GSoC2025Ideaslist-GSoC2025-ApacheSeata(Incubating)EnhancingConnectionPoolManagementforApacheSeataAT/XATransactionModes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
