xxsc0529 opened a new pull request, #7280:
URL: https://github.com/apache/incubator-seata/pull/7280

   <!--
       Licensed to the Apache Software Foundation (ASF) under one or more
       contributor license agreements.  See the NOTICE file distributed with
       this work for additional information regarding copyright ownership.
       The ASF licenses this file to You under the Apache License, Version 2.0
       (the "License"); you may not use this file except in compliance with
       the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
       
       Unless required by applicable law or agreed to in writing, software
       distributed under the License is distributed on an "AS IS" BASIS,
       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
       See the License for the specific language governing permissions and
       limitations under the License.
   -->
   <!-- Please make sure you have read and understood the contributing 
guidelines -->
   
   - [ ] I have registered the PR [changes](../changes).
   
   ### Ⅰ. Describe what this PR did
   Oceanbase's MySQL mode is directly driven by MySQL connections. Due to the 
coding model, it is not convenient to distinguish between the specific patterns 
of querying the database according to connect, and only the oracle mode is 
adapted here. The code logic of Oracle is basically reused, and the reason why 
this part of the code is added is that the Oracle mode of OceanBase can only be 
connected through the OceanBase protocol. Due to the driver problem, the oracle 
mode of OceanBase cannot obtain the value of the auto-increment primary key in 
the oracle mode through getGenerateKeys, so the transaction control of the 
auto-increment SQL statement by sequence number is not supported.
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes 
#97. -->
   close #7279
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   Test code that basically reuses the oracle schema
   org.apache.seata.rm.datasource.exec.OceanBaseInsertExecutorTest
   org.apache.seata.rm.datasource.sql.struct.TableMetaCacheFactoryTest
   
   ### Ⅳ. Describe how to verify it
   use https://github.com/apache/incubator-seata-samples
   
   ### Ⅴ. Special notes for reviews
   oceanbase is ant group open source products.
   the oracle mode of OceanBase cannot obtain the value of the auto-increment 
primary key in the oracle mode through getGenerateKeys, so the transaction 
control of the auto-increment SQL statement by sequence number is not supported.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to