(incubator-seata) branch 2.x updated: test: Simplified complex test testMsgSerialize in RaftSyncMessageTest by separating it into two tests (#7286)

[jimin]

This is an automated email from the ASF dual-hosted git repository.

jimin pushed a commit to branch 2.x
in repository https://gitbox.apache.org/repos/asf/incubator-seata.git


The following commit(s) were added to refs/heads/2.x by this push:
     new 748abd5997 test: Simplified complex test testMsgSerialize in 
RaftSyncMessageTest by separating it into two tests (#7286)
748abd5997 is described below

commit 748abd599789083ce63a6f0def0fcbb56f8a1f54
Author: Monil <16ucs...@lnmiit.ac.in>
AuthorDate: Tue Apr 22 20:59:40 2025 -0700

    test: Simplified complex test testMsgSerialize in RaftSyncMessageTest by 
separating it into two tests (#7286)
---
 changes/en-us/2.x.md                                         |  1 +
 changes/zh-cn/2.x.md                                         |  1 +
 .../org/apache/seata/server/raft/RaftSyncMessageTest.java    | 12 ++++++++----
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/changes/en-us/2.x.md b/changes/en-us/2.x.md
index 7d5e2fa88f..b9d0d2f754 100644
--- a/changes/en-us/2.x.md
+++ b/changes/en-us/2.x.md
@@ -40,6 +40,7 @@ Add changes here for all PR submitted to the 2.x branch.
 
 ### test:
 
+- [[#7286](https://github.com/apache/incubator-seata/pull/7286)] Simplified 
complex test testMsgSerialize in RaftSyncMessageTest by separating it into two 
tests
 - [[#7287](https://github.com/apache/incubator-seata/pull/7287)] Refactored 
testGetErrorMsgWithValidCodeReturnsExpectedMsg to use parameterized unit testing
 
 ### refactor:
diff --git a/changes/zh-cn/2.x.md b/changes/zh-cn/2.x.md
index 7ecd4d6e91..70da3de962 100644
--- a/changes/zh-cn/2.x.md
+++ b/changes/zh-cn/2.x.md
@@ -41,6 +41,7 @@
 
 ### test:
 
+- [[#7286](https://github.com/apache/incubator-seata/pull/7286)] 重构了 
RaftSyncMessageTest 中的 testMsgSerialize 测试，通过拆分为两个独立测试以简化逻辑
 - [[#7287](https://github.com/apache/incubator-seata/pull/7287)] 重构了 CodeTest 
中的 testGetErrorMsgWithValidCodeReturnsExpectedMsg 测试，以简化并使用参数化单元测试。
 
 ### refactor:
diff --git 
a/server/src/test/java/org/apache/seata/server/raft/RaftSyncMessageTest.java 
b/server/src/test/java/org/apache/seata/server/raft/RaftSyncMessageTest.java
index 3e36d55a52..c80899fb68 100644
--- a/server/src/test/java/org/apache/seata/server/raft/RaftSyncMessageTest.java
+++ b/server/src/test/java/org/apache/seata/server/raft/RaftSyncMessageTest.java
@@ -107,21 +107,25 @@ public class RaftSyncMessageTest {
     }
 
     @Test
-    public void testMsgSerialize() throws IOException {
+    public void testGlobalSessionMsgSerializationAndDeserialization() throws 
IOException {
         RaftSyncMessage raftSyncMessage = new RaftSyncMessage();
         RaftGlobalSessionSyncMsg raftSessionSyncMsg = new 
RaftGlobalSessionSyncMsg();
-        RaftBranchSessionSyncMsg raftBranchSessionMsg = new 
RaftBranchSessionSyncMsg();
-        raftBranchSessionMsg.setBranchSession(new 
BranchTransactionDTO("123:123", 1234));
         raftSessionSyncMsg.setGlobalSession(new 
GlobalTransactionDTO("123:123"));
         raftSyncMessage.setBody(raftSessionSyncMsg);
         byte[] msg = RaftSyncMessageSerializer.encode(raftSyncMessage);
         RaftSyncMessage raftSyncMessage1 = 
RaftSyncMessageSerializer.decode(msg);
+        Assertions.assertEquals("123:123", ((RaftGlobalSessionSyncMsg) 
raftSyncMessage1.getBody()).getGlobalSession().getXid());
+    }
+
+    @Test
+    public void testBranchSessionMsgSerializationAndDeserialization() throws 
IOException {
         RaftSyncMessage raftSyncMessage2 = new RaftSyncMessage();
+        RaftBranchSessionSyncMsg raftBranchSessionMsg = new 
RaftBranchSessionSyncMsg();
+        raftBranchSessionMsg.setBranchSession(new 
BranchTransactionDTO("123:123", 1234));
         raftSyncMessage2.setBody(raftBranchSessionMsg);
         byte[] msg2 = RaftSyncMessageSerializer.encode(raftSyncMessage2);
         RaftSyncMessage raftSyncMessageByBranch = 
RaftSyncMessageSerializer.decode(msg2);
         Assertions.assertEquals("123:123", ((RaftBranchSessionSyncMsg) 
raftSyncMessageByBranch.getBody()).getBranchSession().getXid());
-        Assertions.assertEquals("123:123", ((RaftGlobalSessionSyncMsg) 
raftSyncMessage1.getBody()).getGlobalSession().getXid());
         Assertions.assertEquals(1234, ((RaftBranchSessionSyncMsg) 
raftSyncMessageByBranch.getBody()).getBranchSession().getBranchId());
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org