funky-eyes commented on code in PR #7333:
URL: https://github.com/apache/incubator-seata/pull/7333#discussion_r2074920465
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -242,6 +249,12 @@ public void destroy() {
if (mergeSendExecutorService != null) {
mergeSendExecutorService.shutdown();
}
+
+ futures.clear();
Review Comment:
Why is it necessary to clean up these maps? When a RemotingClient executes
the destroy method, this instance should no longer be used. In theory, it
should be garbage collected, or the application is shutting down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
