Copilot commented on code in PR #7328:
URL: https://github.com/apache/incubator-seata/pull/7328#discussion_r2094434368
##########
server/pom.xml:
##########
@@ -165,7 +126,10 @@
<artifactId>seata-spring-autoconfigure-server</artifactId>
<version>${project.version}</version>
</dependency>
-
+ <dependency>
+ <groupId>javax.servlet</groupId>
+ <artifactId>javax.servlet-api</artifactId>
Review Comment:
The `javax.servlet-api` dependency should be marked
`<scope>provided</scope>` to avoid bundling the servlet API in the server
artifact and prevent conflicts.
```suggestion
<artifactId>javax.servlet-api</artifactId>
<scope>provided</scope>
```
##########
server/src/main/java/org/apache/seata/server/Server.java:
##########
@@ -89,7 +90,7 @@ public void start(String[] args) {
XID.setPort(nettyRemotingServer.getListenPort());
UUIDGenerator.init(parameterParser.getServerNode());
ConfigurableListableBeanFactory beanFactory =
- ((GenericWebApplicationContext) ObjectHolder.INSTANCE
+ ((AnnotationConfigApplicationContext) ObjectHolder.INSTANCE
Review Comment:
Casting to the concrete `AnnotationConfigApplicationContext` may fail if a
different context is used. Consider casting to the
`ConfigurableApplicationContext` interface (or
`ConfigurableWebApplicationContext`) to retrieve the bean factory more
generically.
```suggestion
((ConfigurableApplicationContext) ObjectHolder.INSTANCE
```
##########
changes/zh-cn/2.x.md:
##########
@@ -84,4 +84,5 @@
- [JisoLya](https://github.com/JisoLya)
- [YoWuwuuuw](https://github.com/YoWuwuuuw)
+
Review Comment:
Remove the stray `+` line at the end of the changelog to keep the markdown
clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
