Copilot commented on code in PR #764: URL: https://github.com/apache/incubator-seata-go/pull/764#discussion_r2094677296
########## .github/workflows/unit-test.yml: ########## @@ -0,0 +1,78 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: "Unit Test" + +on: + push: + branches: [ master ] + pull_request: + branches: [ "*" ] + types: [opened, synchronize, reopened] + +permissions: + contents: read + +jobs: + unit-test: + name: Unit Test + runs-on: ubuntu-latest + timeout-minutes: 10 + strategy: + matrix: + golang: + - 1.18 + + steps: + - name: "Set up Go" + uses: actions/setup-go@v3 + with: + go-version: ${{ matrix.golang }} + + - name: "Checkout code" + uses: actions/checkout@v3 + with: + submodules: true + + - name: "Cache dependencies" + uses: actions/cache@v3 + with: + path: ~/go/pkg/mod + key: "${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}" + restore-keys: | + "${{ runner.os }}-go-" + + - name: Shutdown default mysql + run: sudo service mysql stop + + + - name: "Run Unit Tests" + run: | + echo "=== Starting Unit Tests ===" + go test -v ./... -race -coverprofile=coverage.txt -covermode=atomic -timeout 10m + if [ $? -ne 0 ]; then + echo "❌ Unit tests failed" + exit 1 + fi + echo "✅ Unit tests completed successfully" + + - name: "Archive test results" Review Comment: The PR description mentions uploading coverage to Codecov, but there’s no `codecov/codecov-action` step in this workflow. Add a step after archiving to upload `coverage.txt` to Codecov. ########## .github/workflows/unit-test.yml: ########## @@ -0,0 +1,78 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: "Unit Test" + +on: + push: + branches: [ master ] + pull_request: + branches: [ "*" ] + types: [opened, synchronize, reopened] + +permissions: + contents: read + +jobs: + unit-test: + name: Unit Test + runs-on: ubuntu-latest + timeout-minutes: 10 + strategy: + matrix: + golang: + - 1.18 + + steps: + - name: "Set up Go" + uses: actions/setup-go@v3 + with: + go-version: ${{ matrix.golang }} + + - name: "Checkout code" + uses: actions/checkout@v3 + with: + submodules: true + + - name: "Cache dependencies" + uses: actions/cache@v3 + with: + path: ~/go/pkg/mod + key: "${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}" + restore-keys: | + "${{ runner.os }}-go-" + + - name: Shutdown default mysql + run: sudo service mysql stop + + + - name: "Run Unit Tests" + run: | + echo "=== Starting Unit Tests ===" + go test -v ./... -race -coverprofile=coverage.txt -covermode=atomic -timeout 10m + if [ $? -ne 0 ]; then + echo "❌ Unit tests failed" + exit 1 + fi + echo "✅ Unit tests completed successfully" Review Comment: [nitpick] This explicit exit check is redundant—GitHub Actions will fail on a non-zero exit by default. Consider simplifying by running `go test ...` directly. ```suggestion go test -v ./... -race -coverprofile=coverage.txt -covermode=atomic -timeout 10m && echo "✅ Unit tests completed successfully" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
