YongGoose commented on code in PR #7356:
URL: https://github.com/apache/incubator-seata/pull/7356#discussion_r2099947268
##########
codecov.yml:
##########
@@ -16,16 +16,16 @@
#
codecov:
- require_ci_to_pass: yes
+ require_ci_to_pass: true
+ branch: 2.x
coverage:
status:
- patch: yes
+ patch: true
project:
default:
threshold: 1%
if_not_found: success
- target: 2.x
- changes: yes #only care the changed files
+ changes: true
Review Comment:
It looks like this setting was added to limit the comparison to only the
modified files, but in reality, it behaves differently.
- https://github.com/apache/incubator-seata/pull/7350/files
It actually detects changes in code coverage even for lines that weren’t
directly modified in the PR or commit.
So I think we need to decide whether to keep it or remove it. What are your
thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
