AlexStocks commented on code in PR #805:
URL:
https://github.com/apache/incubator-seata-go/pull/805#discussion_r2113729763
##########
pkg/saga/statemachine/engine/invoker/invoker.go:
##########
@@ -105,18 +105,14 @@ func (l *LocalServiceInvoker) Invoke(ctx context.Context,
input []any, service s
return l.invokeMethod(instance, method, params), nil
}
-func (l *LocalServiceInvoker) getMethod(serviceName, methodName string,
paramTypes []string) (*reflect.Method, error) {
- key := fmt.Sprintf("%s.%s", serviceName, methodName)
-
- l.mutex.RLock()
- defer l.mutex.RUnlock()
+func (l *LocalServiceInvoker) findAndCacheMethod(key, serviceName, methodName
string) (*reflect.Method, error) {
Review Comment:
findAndCacheMethod 找 gpt 聊下，这个 func name 不是很优雅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
