Copilot commented on code in PR #7430:
URL: https://github.com/apache/incubator-seata/pull/7430#discussion_r2139130410
##########
core/src/main/java/org/apache/seata/core/rpc/netty/http/ParameterParser.java:
##########
@@ -26,19 +26,28 @@
import java.lang.reflect.Parameter;
import java.util.List;
import java.util.Map;
+import java.util.Optional;
+
import org.apache.seata.common.rpc.http.HttpContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import static
com.fasterxml.jackson.databind.SerializationFeature.FAIL_ON_EMPTY_BEANS;
+/**
+ * A utility class for parsing HTTP request parameters and converting them
into Java objects.
+ * Supports various parameter types including request params, request body,
model attributes, etc.
+ */
public class ParameterParser {
private static final Logger LOGGER =
LoggerFactory.getLogger(ParameterParser.class);
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper()
.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
false).configure(FAIL_ON_EMPTY_BEANS, false);
+ private static final String DEFAULT_NONE =
"\n\t\t\n\t\t\n\ue000\ue001\ue002\n\t\t\t\t\n";
Review Comment:
[nitpick] Consider reusing Spring's ValueConstants.DEFAULT_NONE for
consistency, rather than redefining the default magic string here.
##########
seata-spring-autoconfigure/seata-spring-autoconfigure-core/src/main/java/org/apache/seata/spring/boot/autoconfigure/http/RestControllerBeanPostProcessor.java:
##########
@@ -119,6 +130,32 @@ private static void addPathMapping(Object httpController,
List<String> prePaths,
ParamMetaData paramMetaData = new ParamMetaData();
ParamMetaData.ParamConvertType paramConvertType =
MAPPING_PARAM_TYPE.get(parameterAnnotationType);
paramMetaData.setParamConvertType(paramConvertType);
+
+ if (parameterAnnotationType == RequestParam.class) {
+ RequestParam requestParam = (RequestParam) matchedAnnotation;
+ String paramName = null;
+ boolean required = true;
+ String defaultValue = null;
+
+ if (requestParam != null) {
Review Comment:
When no matching RequestParam annotation instance is available (i.e.
matchedAnnotation remains null), consider explicitly populating the parameter
metadata (e.g. using parameters[i].getName()) to avoid leaving the parameter
name null.
```suggestion
String paramName = null;
boolean required = true;
String defaultValue = null;
if (matchedAnnotation != null) {
RequestParam requestParam = (RequestParam)
matchedAnnotation;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
