slievrly commented on PR #7437: URL: https://github.com/apache/incubator-seata/pull/7437#issuecomment-2974298479
> @slievrly Thank you for the clarification! I can now see that PR #7424 indeed addressed this issue. > > I notice a few key points: > > 1. PR [optimize: separate the license from the server and namingserver #7424](https://github.com/apache/incubator-seata/pull/7424) was merged into the 2.4.0 branch, while my PR [optimize: Separate LICENSE and NOTICE files for server and namingserver #7437](https://github.com/apache/incubator-seata/pull/7437) targets the 2.x branch > 2. The two PRs use different implementation approaches (based on the significant code changes in [optimize: separate the license from the server and namingserver #7424](https://github.com/apache/incubator-seata/pull/7424) ) > > Could you please clarify: > > 1. Does my PR still have value, or should it be closed? > > If any part of my dynamic generation approach could be useful, please feel free to use it. Thank you for your guidance! This PR is no longer relevant, since the licenses and notices included in the naming-server and seata-server components are different. We need to split them out as needed to avoid mixing incompatible files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
