YongGoose commented on PR #7408: URL: https://github.com/apache/incubator-seata/pull/7408#issuecomment-2975411750
> > Our workflow requires running the code formatter with Java 8. However, the current version of the Spotless plugin doesn't support the palantirJavaFormat configuration when using Java 8. > > We should also reconsider using `Checkstyle`. If we go that route, it might take some time since we'll need to adjust the `Spotless` configuration accordingly. > > We can disable code style checks on JDK 8 and instead perform code style checks on JDK 17, or have a dedicated pipeline specifically for code style checks. Splitting it sounds like a good idea. Since there are many file conflicts at the moment, I’ll close this PR and open a new one. I’ve been quite busy lately, so I’ll likely be able to work on it around the end of this week. 🥲 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
