xjlgod commented on code in PR #7451:
URL: https://github.com/apache/incubator-seata/pull/7451#discussion_r2159958640
##########
core/src/main/java/org/apache/seata/core/protocol/detector/Http2Detector.java:
##########
@@ -50,17 +54,31 @@ public boolean detect(ByteBuf in) {
@Override
public ChannelHandler[] getHandlers() {
- return new ChannelHandler[]{
- Http2FrameCodecBuilder.forServer().build(),
+ return new ChannelHandler[]
{Http2FrameCodecBuilder.forServer().build(),
new Http2MultiplexHandler(new
ChannelInitializer<Http2StreamChannel>() {
@Override
protected void initChannel(Http2StreamChannel ch) {
final ChannelPipeline p = ch.pipeline();
- p.addLast(new GrpcDecoder());
- p.addLast(new GrpcEncoder());
- p.addLast(serverHandlers);
+ p.addLast(new ChannelInboundHandlerAdapter() {
Review Comment:
Should we not use an inner class here as we did before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
