funky-eyes commented on code in PR #7505:
URL: https://github.com/apache/incubator-seata/pull/7505#discussion_r2191522622
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -137,6 +140,13 @@ public void init() {
new NamedThreadFactory(getThreadPrefix(),
MAX_MERGE_SEND_THREAD));
mergeSendExecutorService.submit(new MergedSendRunnable());
}
+ reconnectExecutor = new ThreadPoolExecutor(
Review Comment:
> Hi @funky-eyes I added a separate thread pool mainly to give it a clear
thread name, so it’s easier to trace when reconnect-related issues happen. But
if that feels unnecessary here, I’m happy to switch to using the existing
`timerExecutor`. Let me know what you think!
I wrote very clearly in the issue why we should reuse the timeoutExecutor. I
suggest you can take a look at the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
