maple525866 opened a new pull request, #7514:
URL: https://github.com/apache/incubator-seata/pull/7514
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
After my research on the error, I found that it cannot be compiled on macOS
14, and the error "cannot find symbol: method registeredChannelsIterator()" is
reported. The main reason is that the unstable API (@UnstableApi) in netty is
used, specifically eventLoop.registeredChannelsIterator() in
collectServerChannels.
My solution:
Avoid using unstable APIs, remove the original collectServerChannels, and
refactor the testChannelInactiveByServer() method.
Results:
1. The code should be able to compile normally on macOS
2. All event handling of ChannelEventHandler is tested
3. The test logic is simplified, cross-platform compatibility is improved,
and each test method does not affect each other
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
fixes #7510
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
mvn clean test
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
