YongGoose commented on code in PR #7492: URL: https://github.com/apache/incubator-seata/pull/7492#discussion_r2233594338
########## common/pom.xml: ########## @@ -48,6 +48,10 @@ <artifactId>httpclient</artifactId> <scope>provided</scope> </dependency> + <dependency> + <groupId>org.apache.httpcomponents.client5</groupId> Review Comment: Since we’ve upgraded to HttpClient version 5, I don’t think there’s a need to keep version 4 anymore. I’m planning to proceed with the changes accordingly, but upgrading the version causes conflicts with other modules that still use HttpClient version 4. Should we upgrade all of them as well? If so, I think it would be better to handle the migration through a separate PR. <img width="2046" height="776" alt="image" src="https://github.com/user-attachments/assets/fcb9b8eb-8479-44a1-9176-7ffe71574433" /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org