Re: [I] The order in AbstractProxyInvocationHandler serves no purpose [incubator-seata]

[via GitHub]

funky-eyes commented on issue #7568:
URL: 
https://github.com/apache/incubator-seata/issues/7568#issuecomment-3149404002

   > [@funky-eyes](https://github.com/funky-eyes)
   > 
   > I’ve noticed that the `setOrder` and `getOrder` methods in 
`AbstractProxyInvocationHandler` are being used more frequently than expected.
   > 
   > How about making the `order` field function properly instead? If we take 
this approach, there would be no need to keep its value fixed.
   > 
   > <img alt="Image" width="200" height="200" 
src="https://private-user-images.githubusercontent.com/104314593/473903903-8b5778af-e326-4feb-a41e-f03f49016a1c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTQyOTA4NTQsIm5iZiI6MTc1NDI5MDU1NCwicGF0aCI6Ii8xMDQzMTQ1OTMvNDczOTAzOTAzLThiNTc3OGFmLWUzMjYtNGZlYi1hNDFlLWYwM2Y0OTAxNmExYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwODA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDgwNFQwNjU1NTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01ODNmMTU3M2ZhNjY0ZDE2MDE5MTU1YmRmMDNjZDdiNTkzOTAyZjEyZDYyODQyYjk0MTYwM2FlODU1OWI3ZmFiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Kt-4PZiBfxsKiLUJnhBFNwwtp_U234o5fnqPL0vwfoc";>
   > If this approach seems too complex, we could setting the value of order in 
AbstractProxyInvocationHandler to 0 and implementing the order method in the 
parent class ProxyInvocationHandler. (As you suggested)
   > 
   > P.S. There are many people in South Korea who would like to contribute to 
Seata!! If this issue is considered a _help-wanted_ type, would it be possible 
to let community members work on the implementation?
   
   I also hope to make the order variable fully functional. However, the 
current default value of order is Integer.MAX_VALUE. After reading the code, I 
noticed that the three current 
implementations—SagaAnnotationActionInterceptorHandler and 
TccActionInterceptorHandler—have already overridden the order method. If the 
third implementation, GlobalTransactionalInterceptorHandler, also overrides the 
order method and sets the order value to 0, we can then fully enable the order 
in AbstractProxyInvocationHandler. This approach will not disrupt the existing 
order and will allow future implementations to take advantage of the order 
method in AbstractProxyInvocationHandler.
   
   Additionally, I’m thrilled to hear this news, as it demonstrates that the 
openness and inclusiveness of the Seata community are being recognized by 
international contributors. Perhaps in the future, the community might even 
have the chance to host an international meetup, either online or offline—who 
knows!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org