flypiggyyoyoyo commented on code in PR #868:
URL:
https://github.com/apache/incubator-seata-go/pull/868#discussion_r2264700377
##########
pkg/saga/statemachine/engine/config/default_statemachine_config.go:
##########
@@ -492,9 +492,20 @@ func (c *DefaultStateMachineConfig) initServiceInvokers()
error {
c.serviceInvokerManager = invoker.NewServiceInvokerManagerImpl()
}
- defaultServiceType := "local"
- if existingInvoker :=
c.serviceInvokerManager.ServiceInvoker(defaultServiceType); existingInvoker ==
nil {
- c.RegisterServiceInvoker(defaultServiceType,
invoker.NewLocalServiceInvoker())
+ if existing := c.serviceInvokerManager.ServiceInvoker("local");
existing == nil {
Review Comment:
Regarding the modification of this method, the main change is adding three
already implemented service invokers during initialization. Users can use them
directly, which is in line with Go's style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
