funky-eyes commented on code in PR #7580:
URL: https://github.com/apache/incubator-seata/pull/7580#discussion_r2265790369
##########
core/src/main/java/org/apache/seata/core/rpc/netty/RmNettyRemotingClient.java:
##########
@@ -320,6 +320,7 @@ public void destroy() {
super.destroy();
initialized.getAndSet(false);
instance = null;
+ transactionServiceGroup = null;
Review Comment:
> By the way, is it unnecessary to set `applicationId` to null in the
destroy method?
Since this instance has already been destroyed, I don't think it is
necessary to retain the value of transactionServiceGroup. Otherwise, when other
test cases are executed, requests may still be sent to the server because
transactionServiceGroup still has a value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
