jihun4452 opened a new pull request, #7587:
URL: https://github.com/apache/incubator-seata/pull/7587
Fixes #7579
- [x] I have read the CONTRIBUTING.md guidelines.
- [x] I have registered the PR changes.
### Ⅰ. Describe what this PR did
- Normalize `AdapterSpringSeataInterceptor#getOrder()`:
- Prefer the explicit order set via `setOrder(...)` to avoid overflow
artifacts from the proxy.
- Clamp values `>= Ordered.LOWEST_PRECEDENCE` to `Integer.MAX_VALUE - 1`
to avoid a tie with Spring’s `TransactionInterceptor`.
- No public API change; only edge-case ordering is adjusted.
### Ⅱ. Does this pull request fix one issue?
Yes.
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Added:
- `order_should_be_less_than_lowest_precedence`
- `order_should_passthrough_when_not_lowest`
### Ⅳ. Describe how to verify it
Run: `./mvnw -pl spring -am -Dtest=AdapterSpringSeataInterceptorTest test
-DfailIfNoTests=false`
Env: macOS, JDK 17, Maven 3.9.x → BUILD SUCCESS locally.
### Ⅴ. Special notes for reviews
Some environments return an overflowed (negative) order from
`ProxyInvocationHandler#getOrder()`, which broke the UT.
Preferring the explicit order and clamping the max value stabilizes
execution precedence and avoids a tie with `TransactionInterceptor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
